refactor: log store sql with spi #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2369 +/- ##
=============================================
+ Coverage 51.36% 51.66% +0.30%
- Complexity 2663 2686 +23
=============================================
Files 529 535 +6
Lines 16983 16932 -51
Branches 2051 2027 -24
=============================================
+ Hits 8723 8748 +25
+ Misses 7432 7372 -60
+ Partials 828 812 -16
|
zjinlei
changed the title
objcoding
reviewed
Mar 7, 2020
| * @author will | ||
| */ | ||
| @LoadLevel(name = "oceanbase") | ||
| public class OceanbaseLogStoreSqls extends MysqlLogStoreSqls { |
There was a problem hiding this comment.
Why here inherit mysql?,This will lead to a strong correlation between Oceanbase and Mysql.
There was a problem hiding this comment.
Because I think oceanbase was compatible with mysql
There was a problem hiding this comment.
Because I think oceanbase was compatible with mysql
is ok.
There was a problem hiding this comment.
Tidb as same as mysql too, please add.
objcoding
reviewed
Mar 8, 2020
| */ | ||
| public class LogStoreSqlsFactory { | ||
|
|
||
| private static Map<String, LogStoreSqls> LOG_STORE_SQLS_MAP = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Should not support multiple database, Can be changed to a single.
objcoding
suggested changes
Mar 8, 2020
…_sql_with_spi # Conflicts: # server/src/main/java/io/seata/server/storage/db/store/LogStoreSqls.java # server/src/test/java/io/seata/server/lock/db/sql/log/LogStoreSqlsFactoryTest.java
…o refactor_log_store_sql_with_spi
zjinlei
reviewed
Apr 5, 2020
| /** | ||
| * @author will | ||
| */ | ||
| public class LogStoreSqlsFactory { |
There was a problem hiding this comment.
#2135 has merged, LogStoreSqlsFactory can be deleted.
zjinlei
reviewed
Apr 5, 2020
|
|
||
| @Override | ||
| public String getInsertGlobalTransactionSQL(String globalTable) { | ||
| throw new NotSupportYetException("unknown dbType:" + CONFIG.getConfig(ConfigurationKeys.STORE_DB_TYPE)); |
There was a problem hiding this comment.
Suggest:
return getInsertGlobalTransactionSQL().replace(GLOBAL_TABLE_PLACEHOLD, globalTable);
abstract String getInsertGlobalTransactionSQL();
Same for other sql
…o refactor_log_store_sql_with_spi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
refactor log store sqls with spi
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews