-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: failureHandler implement can be read from the container #2370
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2370 +/- ##
==========================================
Coverage ? 51.81%
Complexity ? 2699
==========================================
Files ? 517
Lines ? 16761
Branches ? 2028
==========================================
Hits ? 8685
Misses ? 7267
Partials ? 809
|
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not load it from the globalTransactionScanner in starter ?
You mean it's more appropriate? I think my approach is at the bottom of the way, no matter which way he chooses, it can ensure loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
FailureHandler implement can be read from the container
Ⅱ. Does this pull request fix one issue?
#2353
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews