-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: refactor lock store sql with SPI #2372
optimize: refactor lock store sql with SPI #2372
Conversation
…' into refactor_lock_store_sql_with_spi
Codecov Report
@@ Coverage Diff @@
## develop #2372 +/- ##
=============================================
- Coverage 51.51% 51.46% -0.05%
+ Complexity 2667 2664 -3
=============================================
Files 523 529 +6
Lines 16944 16952 +8
Branches 2053 2049 -4
=============================================
- Hits 8728 8724 -4
- Misses 7390 7405 +15
+ Partials 826 823 -3
|
Please add unit test. |
done. |
Please resolve the code conflict. |
# Conflicts: # server/src/main/java/io/seata/server/storage/db/lock/LockStoreDataBaseDAO.java # server/src/main/java/io/seata/server/storage/db/lock/LockStoreSqls.java
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Test Passed.
insert into account_tbl(user_id, money, information) values (?, ?, ?)"
insert into `account_tbl`(user_id, money, information) values (?, ?, ?)"
insert into seatA.account_tbl(user_id, money, information) values (?, ?, ?)"
insert into seatA.`account_tbl`(user_id, money, information) values (?, ?, ?)"
core/src/main/java/io/seata/core/store/db/sql/lock/MysqlLockStoreSql.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/store/db/sql/lock/OceanbaseLockStoreSql.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/store/db/sql/lock/OracleLockStoreSql.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/store/db/sql/lock/PostgresqlLockStoreSql.java
Outdated
Show resolved
Hide resolved
…' into refactor_lock_store_sql_with_spi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Refactor lock store sql with spi.