Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: refactor lock store sql with SPI #2372

Merged
merged 23 commits into from
Apr 1, 2020

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

Refactor lock store sql with spi.

@objcoding objcoding changed the title Refactor lock store sql with spi Optimize: refactor lock store sql with spi. Mar 7, 2020
@codecov-io
Copy link

codecov-io commented Mar 8, 2020

Codecov Report

Merging #2372 into develop will decrease coverage by 0.04%.
The diff coverage is 21.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2372      +/-   ##
=============================================
- Coverage      51.51%   51.46%   -0.05%     
+ Complexity      2667     2664       -3     
=============================================
  Files            523      529       +6     
  Lines          16944    16952       +8     
  Branches        2053     2049       -4     
=============================================
- Hits            8728     8724       -4     
- Misses          7390     7405      +15     
+ Partials         826      823       -3     
Impacted Files Coverage Δ Complexity Δ
...a/core/store/db/sql/lock/AbstractLockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...o/seata/core/store/db/sql/lock/H2LockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ta/core/store/db/sql/lock/LockStoreSqlFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eata/core/store/db/sql/lock/MysqlLockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../core/store/db/sql/lock/OceanbaseLockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ata/core/store/db/sql/lock/OracleLockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...core/store/db/sql/lock/PostgresqlLockStoreSql.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/server/storage/db/lock/LockStoreDataBaseDAO.java 56.99% <52.94%> (-0.23%) 26.00 <1.00> (ø)
... and 5 more

@l81893521 l81893521 added the Do Not Merge Do not merge into develop label Mar 10, 2020
@l81893521
Copy link
Contributor

Please add unit test.

@objcoding
Copy link
Contributor Author

Please add unit test.

done.

@l81893521
Copy link
Contributor

Please resolve the code conflict.

# Conflicts:
#	server/src/main/java/io/seata/server/storage/db/lock/LockStoreDataBaseDAO.java
#	server/src/main/java/io/seata/server/storage/db/lock/LockStoreSqls.java
@objcoding
Copy link
Contributor Author

Please resolve the code conflict.

done.

@slievrly slievrly added this to the 1.2.0 milestone Mar 23, 2020
@slievrly slievrly removed the Do Not Merge Do not merge into develop label Mar 27, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test Passed.

insert into account_tbl(user_id, money, information) values (?, ?, ?)"
insert into `account_tbl`(user_id, money, information) values (?, ?, ?)"
insert into seatA.account_tbl(user_id, money, information) values (?, ?, ?)"
insert into seatA.`account_tbl`(user_id, money, information) values (?, ?, ?)"

@slievrly slievrly changed the title Optimize: refactor lock store sql with spi. optimize: refactor lock store sql with SPI Apr 1, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 494f673 into apache:develop Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants