feature: support custom service name when registering with nacos #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvShrimp
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2379 +/- ##
=============================================
- Coverage 51.45% 51.43% -0.02%
+ Complexity 2664 2662 -2
=============================================
Files 529 529
Lines 16956 16956
Branches 2051 2051
=============================================
- Hits 8724 8722 -2
Misses 7408 7408
- Partials 824 826 +2
|
slievrly
reviewed
Mar 10, 2020
| @@ -203,6 +205,14 @@ private static String getClusterName() { | |||
| return cluster; | |||
| } | |||
|
|
|||
| private static String getServiceName() { | |||
| String serviceName = FILE_CONFIG.getConfig(getNacosApplicationFileKey()); | |||
There was a problem hiding this comment.
getConfig support defaultValue
There was a problem hiding this comment.
ok，i have already optimize it
| @@ -43,10 +43,12 @@ | |||
| public class NacosRegistryServiceImpl implements RegistryService<EventListener> { | |||
| private static final String DEFAULT_NAMESPACE = ""; | |||
| private static final String DEFAULT_CLUSTER = "default"; | |||
| private static final String DEFAULT_APPLICATION = "seata"; | |||
| private static final String PRO_SERVER_ADDR_KEY = "serverAddr"; | |||
| @@ -43,10 +43,12 @@ | |||
| public class NacosRegistryServiceImpl implements RegistryService<EventListener> { | |||
| private static final String DEFAULT_NAMESPACE = ""; | |||
| private static final String DEFAULT_CLUSTER = "default"; | |||
| private static final String DEFAULT_APPLICATION = "seata"; | |||
There was a problem hiding this comment.
ok，i will optimize it
| @@ -3,6 +3,7 @@ registry { | |||
| type = "file" | |||
|
|
|||
| nacos { | |||
| application = "seata" | |||
There was a problem hiding this comment.
where your client configuration item application
… with nacos, add the client configuration
Thx, i have already add the client configuration |
|
please resolve code conflicts |
i have already resolve the code conflicts |
slievrly
changed the title
zjinlei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with nacos
Ⅰ. Describe what this PR did
Set configurable service name automatically when registering with nacos
Ⅱ. Does this pull request fix one issue?
fixes #2355
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews