feature: support XA transaction mode #2381

sharajava · 2020-03-09T10:56:50Z

Ⅰ. Describe what this PR did

Provide XA mode to Seata. Issue #2022

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

all test cases can be found in XAModeTest2

Ⅴ. Special notes for reviews

sync

# Conflicts: # server/src/main/java/com/alibaba/fescar/server/coordinator/DefaultCoordinator.java

…try other application on the same resource.

…ormal SELECT SQL

# Conflicts: # test/src/main/java/com/alibaba/fescar/test/DataSourceBasicTest.java

# Conflicts: # rm-datasource/src/main/java/com/alibaba/fescar/rm/datasource/sql/druid/MySQLInsertRecognizer.java # rm-datasource/src/main/java/com/alibaba/fescar/rm/datasource/sql/struct/TableMetaCache.java # test/src/main/java/com/alibaba/fescar/test/DataSourceBasicTest.java

…local

…m BranchSession

…n/branchsession exists while restoring

slievrly · 2020-03-10T03:13:17Z

test/src/test/java/io/seata/xa/XAModeTest2.java

+    private static final String mockXid = "127.0.0.1:8091:" + testTid;
+    private static final long mockBranchId = testTid + 1;
+
+    private static final String pg_jdbcUrl = "jdbc:postgresql://127.0.0.1:5432/postgres";


Unable to connect to 127.0.0.1 database, CI occurred a large number of error logs. Please use mock or disable, and remove all printf logs.

zhangthen

Good job~

codecov-io · 2020-03-23T03:36:36Z

Codecov Report

Merging #2381 into develop will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2381   +/-   ##
==========================================
  Coverage      50.94%   50.94%           
  Complexity      2763     2763           
==========================================
  Files            551      551           
  Lines          17569    17569           
  Branches        2063     2063           
==========================================
  Hits            8950     8950           
  Misses          7775     7775           
  Partials         844      844

sharajava · 2020-03-24T05:26:19Z

Samples For XA mode: apache/incubator-seata-samples#324

zhangthen

看了设计方案，本地跑了demo，无问题

rm-datasource/pom.xml

rm-datasource/src/main/java/io/seata/rm/BaseDataSourceResource.java

rm-datasource/src/main/java/io/seata/rm/datasource/xa/ConnectionProxyXA.java

rm-datasource/src/main/java/io/seata/rm/datasource/xa/ExecuteTemplateXA.java

slievrly · 2020-04-07T09:38:58Z

rm-datasource/src/main/java/io/seata/rm/datasource/xa/ResourceManagerXA.java

+        XAXid xaBranchXid = XAXidBuilder.build(xid, branchId);
+        Resource resource = dataSourceCache.get(resourceId);
+        if (resource instanceof AbstractDataSourceProxyXA) {
+            try (ConnectionProxyXA connectionProxyXA = ((AbstractDataSourceProxyXA)resource).getConnectionForXAFinish(xaBranchXid)) {


clientA, clientB->TC clientA branchCommit but clientA ->TC channel is bad and XAConn is ok, so TC send request to clientB.

Yes, such cases should be considered in enhancement later.

Just keep the basic logic by now.

slievrly · 2020-04-07T09:57:42Z

rm-datasource/src/main/java/io/seata/rm/datasource/xa/ResourceManagerXA.java

+                    return BranchStatus.PhaseTwo_Rollbacked;
+                }
+            } catch (XAException xe) {
+                throw new TransactionException("XA Exception " + xe.getMessage(), xe);


throw exception will result in encode error.

Merged SQLException and XAException cases.

slievrly · 2020-04-07T09:57:51Z

rm-datasource/src/main/java/io/seata/rm/datasource/xa/ResourceManagerXA.java

+                }
+            }
+        } else {
+            throw new TransactionException("Unknown Resource for XA resource " + resourceId + " " + resource);


throw exception will result in encode error.

In fact, this is a case that SHOULD NEVER happen.

Just merged XAException and SQLException into retryable status.

slievrly · 2020-04-07T10:53:01Z

apache/incubator-seata-samples#324 (comment)
case check

http://localhost:8084/purchase committed
http://localhost:8084/purchase?rollback=true rollbacked
http://localhost:8084/purchase , accountXa service down , rollbacked

slievrly

LGTM

sharajava added 30 commits January 16, 2019 21:48

Merge pull request #2 from alibaba/develop

9986990

sync

issue apache#110 fix RM channel management

24f4a0f

Merge branch 'develop'

45ebe80

Merge branch 'rm_channel_fix'

60c78a0

# Conflicts: # server/src/main/java/com/alibaba/fescar/server/coordinator/DefaultCoordinator.java

fix merge mistake

ad7e385

issue apache#110 enhance: if no channel found on my application set, …

5cc051f

…try other application on the same resource.

Merge branch 'develop'

761d92c

bug fix and enhance

198de59

Merge branch 'develop'

8270eb7

issue apache#110 enhance the original fix

c841e55

Merge branch 'develop'

0e0657f

Merge branch 'develop'

320193a

Merge branch 'upstream_develop'

de0279b

issue apache#227 SQLVisitorFactory should recognize FOR UPDATE from n…

3c5ef32

…ormal SELECT SQL

issue apache#24 Should support SQL with table alias

563ca53

Merge branch 'upstream_develop'

4ac8ad0

remove useless import

8405d3a

issue apache#255 Should work with case-sensitive database

2ef18c4

Merge branch 'upstream_develop'

baaae5f

# Conflicts: # test/src/main/java/com/alibaba/fescar/test/DataSourceBasicTest.java

issue # 313 refactor on GlobalTransactionContext to be out of thread …

2a9285e

…local

Merge branch 'upstream_develop'

d240cf5

Merge branch 'upstream_develop'

6cf4d86

Merge branch 'upstream_develop'

cae10c2

issue apache#295 reload sessions and locks when restart

9519290

Merge branch 'upstream_develop'

b3d9e7d

issue apache#391 remove applicationId and transactionServiceGroup fro…

fc3cbc5

…m BranchSession

Merge branch 'upstream_develop'

55abc3f

issue apache#395 Bug: should NOT throw exception when no globalsessio…

802cb5a

…n/branchsession exists while restoring

Merge branch 'upstream_develop'

91a80a4

sharajava requested a review from zhangthen March 9, 2020 13:56

sharajava self-assigned this Mar 9, 2020

sharajava added the type: feature Category issues or prs related to feature request. label Mar 9, 2020

sharajava requested a review from slievrly March 9, 2020 13:57

sharajava added 2 commits March 10, 2020 07:18

fix oracle jdbc driver version issue

8016665

no direct dependency on ojdbc

db7fc6b

slievrly reviewed Mar 10, 2020

View reviewed changes

remove all dependency on ojdbc

0d07974

zhangthen reviewed Mar 10, 2020

View reviewed changes

slievrly and others added 6 commits March 15, 2020 18:35

Merge branch 'develop' into xa_mode_pr

cac2b0c

Merge branch 'upstream_develop' into xa_mode_pr

3eb5659

disable test cases which requires db

9df59c3

add unit tests

c3c2d0c

Merge branch 'upstream_develop' into xa_mode_pr

d73fa94

add a case for create statement

b8eb1f2

apache deleted a comment from codecov-io Mar 23, 2020

Merge branch 'develop' into xa_mode_pr

8ac9c88

zhangthen approved these changes Apr 2, 2020

View reviewed changes

slievrly reviewed Apr 7, 2020

View reviewed changes

Merge branch 'develop' into xa_mode_pr

01acbf0

sharajava and others added 3 commits April 9, 2020 16:36

Fix according to code review comments

7326682

Merge branch 'xa_mode_pr' of github.com:sharajava/fescar into xa_mode_pr

3a7b429

Merge branch 'develop' into xa_mode_pr

fef37c7

slievrly approved these changes Apr 9, 2020

View reviewed changes

slievrly merged commit 084708c into apache:develop Apr 9, 2020

slievrly added this to the 1.2.0 milestone Apr 14, 2020

wangliang181230 mentioned this pull request Jul 24, 2020

Some Features Request with AT/XA/TCC mode #2300

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support XA transaction mode #2381

feature: support XA transaction mode #2381

sharajava commented Mar 9, 2020

slievrly Mar 10, 2020

zhangthen left a comment

codecov-io commented Mar 23, 2020 •

edited

sharajava commented Mar 24, 2020

zhangthen left a comment

slievrly Apr 7, 2020

sharajava Apr 9, 2020

slievrly Apr 7, 2020

sharajava Apr 9, 2020

slievrly Apr 7, 2020

sharajava Apr 8, 2020

slievrly commented Apr 7, 2020 •

edited

slievrly left a comment

feature: support XA transaction mode #2381

feature: support XA transaction mode #2381

Conversation

sharajava commented Mar 9, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly Mar 10, 2020

Choose a reason for hiding this comment

zhangthen left a comment

Choose a reason for hiding this comment

codecov-io commented Mar 23, 2020 • edited

Codecov Report

sharajava commented Mar 24, 2020

zhangthen left a comment

Choose a reason for hiding this comment

slievrly Apr 7, 2020

Choose a reason for hiding this comment

sharajava Apr 9, 2020

Choose a reason for hiding this comment

slievrly Apr 7, 2020

Choose a reason for hiding this comment

sharajava Apr 9, 2020

Choose a reason for hiding this comment

slievrly Apr 7, 2020

Choose a reason for hiding this comment

sharajava Apr 8, 2020

Choose a reason for hiding this comment

slievrly commented Apr 7, 2020 • edited

slievrly left a comment

Choose a reason for hiding this comment

codecov-io commented Mar 23, 2020 •

edited

slievrly commented Apr 7, 2020 •

edited