Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize RegistryFactory singleton pattern and RegistryType judge mode #2382

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented Mar 9, 2020

… judge mode

Ⅰ. Describe what this PR did

optimize RegistryFactory singleton pattern and RegistryType judge mode

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #2382 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2382      +/-   ##
=============================================
+ Coverage      51.83%   51.86%   +0.03%     
+ Complexity      2702     2701       -1     
=============================================
  Files            517      517              
  Lines          16776    16768       -8     
  Branches        2033     2027       -6     
=============================================
+ Hits            8695     8697       +2     
+ Misses          7272     7260      -12     
- Partials         809      811       +2
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/discovery/registry/RegistryFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...java/io/seata/discovery/registry/RegistryType.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.35% <0%> (-0.52%) 28% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84% <0%> (-0.45%) 72% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 57.14% <0%> (+0.63%) 30% <0%> (+1%) ⬆️
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 11.55% <0%> (+1%) 4% <0%> (ø) ⬇️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei added this to the 1.2.0 milestone Mar 12, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 6c97852 into apache:develop Mar 12, 2020
@ph3636 ph3636 deleted the RegistryFactory branch March 20, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants