Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix configuration item containing spaces #2390

Merged
merged 6 commits into from
Mar 16, 2020

Conversation

objcoding
Copy link
Contributor

No description provided.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: script and config txt. bugfix: fix configuration item containing spaces Mar 11, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.2.0 milestone Mar 12, 2020
@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #2390 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2390   +/-   ##
==========================================
  Coverage      51.81%   51.81%           
  Complexity      2698     2698           
==========================================
  Files            517      517           
  Lines          16761    16761           
  Branches        2028     2028           
==========================================
  Hits            8685     8685           
  Misses          7267     7267           
  Partials         809      809           

@slievrly slievrly merged commit 8f7b400 into apache:develop Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants