bugfix: configuration exceptions lead to increased CPU usage #2391

funky-eyes · 2020-03-11T03:06:54Z

Ⅰ. Describe what this PR did

optimize file configuration reading

Ⅱ. Does this pull request fix one issue?

#2387

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io · 2020-03-11T03:15:50Z

Codecov Report

Merging #2391 into develop will decrease coverage by 0.00%.
The diff coverage is 20.00%.

@@              Coverage Diff              @@
##             develop    #2391      +/-   ##
=============================================
- Coverage      51.80%   51.80%   -0.01%     
  Complexity      2696     2696              
=============================================
  Files            517      517              
  Lines          16761    16764       +3     
  Branches        2028     2028              
=============================================
+ Hits            8683     8684       +1     
- Misses          7267     7269       +2     
  Partials         811      811

Impacted Files	Coverage Δ	Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java	`36.43% <20.00%> (-0.08%)`	`6.00 <0.00> (ø)`

l81893521 · 2020-03-11T09:01:49Z

config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java

@@ -306,7 +308,9 @@ public FileListener(String dataId, ConfigurationChangeListener listener) {

        @Override
        public void onChangeEvent(ConfigurationChangeEvent event) {
-            while (true) {
+            ScheduledExecutorService onChangeEventExecutor =


I think ScheduledExecutorService would be instantiate more time if I listen different config.

PTAL @l81893521

threefish · 2020-03-11T13:34:40Z

测试当前PR分支

结果

复现错误，CPU性能正常。理论上在生产环境是不会产生该异常。

复现错误

当前classLoader: RestartClassLoader
启动服务后，修改controller类方法代码，触发devtool restart。
devtool restart 后每隔1秒输出一次异常信息。
服务无法正常访问。

异常信息

2020-03-11 21:23:59.362 INFO com.alibaba.nacos.client.naming Line:195 - current ips:(0) service: DEFAULT_GROUP@@serverAddr -> [] 2020-03-11 21:23:59.362 INFO com.alibaba.nacos.client.naming Line:195 - current ips:(0) service: DEFAULT_GROUP@@flow-center-business-demo-client -> [] 2020-03-11 21:23:59.964 ERROR io.seata.config.FileConfiguration Line:323 - fileListener execute error:org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@af3a716 has been closed already java.lang.IllegalStateException: org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@af3a716 has been closed already at org.springframework.context.support.AbstractApplicationContext.assertBeanFactoryActive(AbstractApplicationContext.java:1092) at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1125) at io.seata.spring.boot.autoconfigure.provider.SpringBootConfigurationProvider.get(SpringBootConfigurationProvider.java:93) at io.seata.spring.boot.autoconfigure.provider.SpringBootConfigurationProvider.access$100(SpringBootConfigurationProvider.java:43) at io.seata.spring.boot.autoconfigure.provider.SpringBootConfigurationProvider$1.intercept(SpringBootConfigurationProvider.java:56) at io.seata.config.FileConfiguration$$EnhancerByCGLIB$$862af1eb.getConfig(<generated>) at io.seata.config.FileConfiguration$FileListener.lambda$onChangeEvent$0(FileConfiguration.java:315) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset$$$capture(FutureTask.java:308) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748)

funky-eyes · 2020-03-11T14:49:28Z

@threefish how long will it not output an exception?or is it always exist?

l81893521 · 2020-03-12T09:34:33Z

config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java

+                try {
+                    Thread.sleep(LISTENER_CONFIG_INTERNAL);
+                } catch (InterruptedException e) {
+                    e.printStackTrace();


use

LOGGER.error

instead of

e.printStackTrace();

use

LOGGER.error

instead of

e.printStackTrace();

ok

xingfudeshi · 2020-03-12T13:31:46Z

config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java

+                    LOGGER.error("fileListener execute error:{}", exx.getMessage());
+                }
+                try {
+                    Thread.sleep(LISTENER_CONFIG_INTERNAL);


Please help correct the spelling by the way.Thank you!
LISTENER_CONFIG_INTERNAL->LISTENER_CONFIG_INTERVAL

LISTENER_CONFIG_INTERVAL

ok

cpu has behaved normally。

cpu has behaved normally。

If there are no questions, please reply to PTAL separately

threefish · 2020-03-13T01:27:10Z

cpu has behaved normally。thanks

l81893521

LGTM

zjinlei

LGTM

slievrly

LGTM

optimize file configuration reading

0e3574c

l81893521 reviewed Mar 11, 2020

View reviewed changes

funky-eyes added 3 commits March 11, 2020 17:12

optimize code logic

9671e72

Merge branch 'develop' into fix_error_sleep

bf7e314

adjust code logic

dfbbacf

funky-eyes requested a review from l81893521 March 11, 2020 12:15

remove redundant abnormal output

7b9bc5f

zjinlei added this to the 1.2.0 milestone Mar 12, 2020

l81893521 reviewed Mar 12, 2020

View reviewed changes

funky-eyes added 2 commits March 12, 2020 17:38

adjust the code

0b99f2a

Merge branch 'develop' into fix_error_sleep

6d8013c

xingfudeshi reviewed Mar 12, 2020

View reviewed changes

modify the variable name

f522ec7

l81893521 approved these changes Mar 16, 2020

View reviewed changes

zjinlei added 2 commits March 17, 2020 13:17

Merge branch 'develop' into fix_error_sleep

5d23e59

Merge branch 'develop' into fix_error_sleep

f13fb0d

zjinlei approved these changes Mar 17, 2020

View reviewed changes

slievrly changed the title ~~optimize:file configuration reading~~ bugfix: configuration exceptions lead to increased CPU usage Mar 17, 2020

slievrly approved these changes Mar 17, 2020

View reviewed changes

slievrly merged commit bd61afe into apache:develop Mar 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bugfix: configuration exceptions lead to increased CPU usage #2391

bugfix: configuration exceptions lead to increased CPU usage #2391

funky-eyes commented Mar 11, 2020

codecov-io commented Mar 11, 2020 •

edited

l81893521 Mar 11, 2020

funky-eyes Mar 11, 2020

threefish commented Mar 11, 2020

funky-eyes commented Mar 11, 2020

l81893521 Mar 12, 2020

funky-eyes Mar 12, 2020

xingfudeshi Mar 12, 2020

funky-eyes Mar 12, 2020

threefish Mar 12, 2020

funky-eyes Mar 12, 2020

threefish commented Mar 13, 2020

l81893521 left a comment

zjinlei left a comment

slievrly left a comment

bugfix: configuration exceptions lead to increased CPU usage #2391

bugfix: configuration exceptions lead to increased CPU usage #2391

Conversation

funky-eyes commented Mar 11, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented Mar 11, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

threefish commented Mar 11, 2020

测试当前PR分支

结果

复现错误

异常信息

funky-eyes commented Mar 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

threefish commented Mar 13, 2020

l81893521 left a comment

Choose a reason for hiding this comment

zjinlei left a comment

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

codecov-io commented Mar 11, 2020 •

edited