Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:optimize the magic num of date at UUIDGenerator #2400

Merged
merged 2 commits into from
Mar 15, 2020
Merged

optimize:optimize the magic num of date at UUIDGenerator #2400

merged 2 commits into from
Mar 15, 2020

Conversation

lightClouds917
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize:optimize the magic num of date at UUIDGenerator

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #2400 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2400      +/-   ##
=============================================
- Coverage      51.81%   51.80%   -0.01%     
+ Complexity      2698     2696       -2     
=============================================
  Files            517      517              
  Lines          16759    16761       +2     
  Branches        2028     2028              
=============================================
  Hits            8683     8683              
  Misses          7267     7267              
- Partials         809      811       +2     
Impacted Files Coverage Δ Complexity Δ
...r/src/main/java/io/seata/server/UUIDGenerator.java 65.62% <100.00%> (+2.29%) 5.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.35% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 84.00% <0.00%> (-0.45%) 72.00% <0.00%> (-1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit c35082c into apache:develop Mar 15, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants