Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:optimize the rm and tm register log #2402

Merged
merged 9 commits into from
Mar 18, 2020
Merged

optimize:optimize the rm and tm register log #2402

merged 9 commits into from
Mar 18, 2020

Conversation

lightClouds917
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize:optimize the rm and tm register log

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #2402 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2402      +/-   ##
============================================
- Coverage      51.81%   51.8%   -0.01%     
- Complexity      2698    2699       +1     
============================================
  Files            517     517              
  Lines          16764   16772       +8     
  Branches        2028    2030       +2     
============================================
+ Hits            8686    8689       +3     
- Misses          7269    7275       +6     
+ Partials         809     808       -1
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/rpc/netty/TmRpcClient.java 63.04% <0%> (-2.87%) 9 <0> (ø)
...ata/core/rpc/DefaultServerMessageListenerImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.95%) 29% <0%> (ø) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zjinlei
zjinlei previously approved these changes Mar 18, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei dismissed their stale review March 18, 2020 05:42

duplicate call

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 166ecfb into apache:develop Mar 18, 2020
Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.2.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants