Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Inaccurate judgment will lead to NPE. #2407

Merged
merged 6 commits into from
Mar 17, 2020

Conversation

threefish
Copy link
Contributor

Ⅰ. Describe what this PR did

Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.

Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.
Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #2407 into develop will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2407      +/-   ##
=============================================
- Coverage      51.67%   51.65%   -0.03%     
  Complexity      2696     2696              
=============================================
  Files            517      517              
  Lines          16761    16741      -20     
  Branches        1998     1989       -9     
=============================================
- Hits            8662     8648      -14     
+ Misses          7265     7260       -5     
+ Partials         834      833       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/integration/http/XidResource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 90.90% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
...obuf/convertor/BranchRollbackRequestConvertor.java 92.00% <0.00%> (-4.00%) 3.00% <0.00%> (ø%)
...ain/java/io/seata/config/ConfigurationFactory.java 52.08% <0.00%> (-0.98%) 4.00% <0.00%> (ø%)
...server/store/file/FileTransactionStoreManager.java 56.50% <0.00%> (-0.64%) 29.00% <0.00%> (ø%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 66.35% <0.00%> (-0.32%) 24.00% <0.00%> (ø%)
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.77% <0.00%> (-0.15%) 21.00% <0.00%> (ø%)
...in/java/io/seata/server/session/BranchSession.java 78.03% <0.00%> (-0.08%) 44.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (ø) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (ø) 3.00% <0.00%> (ø%)
... and 22 more

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added the first-time contributor first-time contributor label Mar 16, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimization: Inaccurate judgment will lead to NullPointerException. optimize: Inaccurate judgment will lead to NullPointerException. Mar 16, 2020
@zjinlei zjinlei changed the title optimize: Inaccurate judgment will lead to NullPointerException. optimize: Inaccurate judgment will lead to NPE. Mar 16, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 7f385b2 into apache:develop Mar 17, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants