-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Inaccurate judgment will lead to NPE. #2407
Conversation
Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.
Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.
Codecov Report
@@ Coverage Diff @@
## develop #2407 +/- ##
=============================================
- Coverage 51.67% 51.65% -0.03%
Complexity 2696 2696
=============================================
Files 517 517
Lines 16761 16741 -20
Branches 1998 1989 -9
=============================================
- Hits 8662 8648 -14
+ Misses 7265 7260 -5
+ Partials 834 833 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
integration/http/src/main/java/io/seata/integration/http/XidResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Inaccurate judgment will lead to NullPointerException. After the global web exception is caught, the successful return result will be misjudged as a failure.