Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix missing sequence in undo_log table #2408

Merged
merged 2 commits into from
Mar 17, 2020
Merged

bugfix: fix missing sequence in undo_log table #2408

merged 2 commits into from
Mar 17, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix missing sequence in undo_log table

Ⅱ. Does this pull request fix one issue?

fix #2289

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #2408 into develop will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2408      +/-   ##
=============================================
- Coverage       51.8%   51.65%   -0.15%     
  Complexity      2696     2696              
=============================================
  Files            517      517              
  Lines          16761    16741      -20     
  Branches        2028     1989      -39     
=============================================
- Hits            8683     8648      -35     
+ Misses          7267     7260       -7     
- Partials         811      833      +22
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0%> (-9.53%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 90.9% <0%> (-9.1%) 3% <0%> (ø)
...obuf/convertor/BranchRollbackRequestConvertor.java 92% <0%> (-8%) 3% <0%> (ø)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0%> (-4.77%) 3% <0%> (ø)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
... and 20 more

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 05f157c into apache:develop Mar 17, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgreSQL lack undo_log sequence
4 participants