optimize: reduce the db and network request when undoLog or lockKey is empty #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightClouds917
changed the title
slievrly
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2409 +/- ##
=============================================
- Coverage 51.48% 51.08% -0.41%
+ Complexity 2803 2769 -34
=============================================
Files 553 550 -3
Lines 17685 17530 -155
Branches 2088 2062 -26
=============================================
- Hits 9105 8955 -150
- Misses 7727 7733 +6
+ Partials 853 842 -11
|
lightClouds917
changed the title
…/seata into optimize_useless_register
|
@zjinlei PTAL,THS |
zjinlei
reviewed
Apr 12, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/ConnectionProxy.java
Outdated
Show resolved
Hide resolved
…/seata into optimize_useless_register
slievrly
reviewed
Apr 13, 2020
| if (context.hasUndoLog()) { | ||
| if (context.hasUndoLog()) { | ||
| try { | ||
| register(); |
There was a problem hiding this comment.
I think it's better to put it in registers and flushUndoLogs.
if there is no undolog why flushUndoLogs method execution without judgment
There was a problem hiding this comment.
I have finish it.PTAL
…/seata into optimize_useless_register
lightClouds917
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
issue
optimize: unnecessary to register branch transaction when undo is empty
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews