optimize: changed xid generation strategy to snowflake #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2412 +/- ##
==========================================
Coverage 50.93% 50.93%
Complexity 2813 2813
==========================================
Files 557 557
Lines 17823 17823
Branches 2076 2076
==========================================
Hits 9079 9079
Misses 7858 7858
Partials 886 886 |
1 task
l81893521
reviewed
May 3, 2020
ok |
zjinlei
reviewed
May 3, 2020
funky-eyes
changed the title
zjinlei
reviewed
May 3, 2020
zjinlei
reviewed
May 3, 2020
zjinlei
reviewed
May 3, 2020
slievrly
reviewed
May 4, 2020
| if (lastTimestamp == timestamp) { | ||
| sequence = (sequence + 1) & sequenceMask; | ||
| if (sequence == 0) { | ||
| timestamp = tilNextMillis(lastTimestamp); |
There was a problem hiding this comment.
need some output shows that the sequence is not enough to use?
slievrly
reviewed
May 4, 2020
| } | ||
| lastTimestamp = timestamp; | ||
| } | ||
| return ((timestamp - twepoch) << timestampLeftShift) | (workerId << workerIdShift) | sequence; |
There was a problem hiding this comment.
How do you ensure order when timestamp-twepoch is greater than 2^22?
|
@long187 will this pr have any effect on the field length of saga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize xid generation strategy
Ⅱ. Does this pull request fix one issue?
#2416
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews