Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added fst serialization #2418

Merged
merged 11 commits into from
Mar 20, 2020
Merged

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 17, 2020

Ⅰ. Describe what this PR did

added fst serialization

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

transport.serialization=fst

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #2418 into develop will increase coverage by 0.03%.
The diff coverage is 80%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2418      +/-   ##
=============================================
+ Coverage      51.72%   51.75%   +0.03%     
- Complexity      2664     2699      +35     
=============================================
  Files            517      518       +1     
  Lines          16801    16793       -8     
  Branches        2031     2030       -1     
=============================================
+ Hits            8690     8692       +2     
+ Misses          7293     7290       -3     
+ Partials         818      811       -7
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/serializer/SerializerType.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/io.seata.serializer.fst/FstSerializer.java 100% <100%> (ø) 3 <3> (?)
...rc/main/java/io/seata/common/util/StringUtils.java 9.9% <0%> (-6.77%) 8% <0%> (-3%)
...in/java/io/seata/server/session/GlobalSession.java 84% <0%> (-1.33%) 72% <0%> (+1%)
...in/java/io/seata/server/session/SessionHolder.java 56.09% <0%> (-0.53%) 17% <0%> (-1%)
.../java/io/seata/tm/api/transaction/Propagation.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
...c/main/java/io/seata/server/store/StoreConfig.java 83.33% <0%> (ø) 5% <0%> (ø) ⬇️
...o/seata/server/storage/db/lock/DataBaseLocker.java
...a/tm/api/transaction/SuspendedResourcesHolder.java
...erver/storage/file/session/FileSessionManager.java
... and 41 more

@funky-eyes funky-eyes changed the title Feature: added fst serialization WIP: added fst serialization Mar 18, 2020
@funky-eyes funky-eyes changed the title WIP: added fst serialization Feature: added fst serialization Mar 18, 2020
@zjinlei zjinlei added this to the 1.2.0 milestone Mar 18, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,optimize serializable class registry.

@jsbxyyx jsbxyyx merged commit be54224 into apache:develop Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants