Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix http testcase run failed #2419

Merged
merged 73 commits into from
Apr 9, 2020
Merged

bugfix: fix http testcase run failed #2419

merged 73 commits into from
Apr 9, 2020

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Mar 17, 2020

Ⅰ. Describe what this PR did

Fix http testcase run failed

Ⅱ. Does this pull request fix one issue?

fixes #2414

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

run httpTest

Ⅴ. Special notes for reviews

wangxb and others added 30 commits October 11, 2019 15:06
1、do not need to config in springboot env
2、import HttpAutoConfiguration bean for common spring env
if run, must be start a http server by oneself
if run, must be start a http server by oneself
Found a bug in the case of multiple requests,
The reason for troubleshooting is that after the execution of the http interface method, the xid in the thread is not released. Since the tomcat uses the thread pool to handle the connection, the xid is reused, and the xid does not exist on the server.
Repair method: release the xid after the interface method is finished, like dubbo
@zjinlei zjinlei added this to the 1.2.0 milestone Mar 18, 2020
@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #2419 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2419   +/-   ##
==========================================
  Coverage      51.72%   51.72%           
  Complexity      2698     2698           
==========================================
  Files            535      535           
  Lines          16959    16959           
  Branches        2027     2027           
==========================================
  Hits            8772     8772           
  Misses          7368     7368           
  Partials         819      819           

@slievrly slievrly changed the title bugfix:Fix http testcase run failed bugfix: fix http testcase run failed Mar 20, 2020
@zjinlei zjinlei added the bug label Mar 29, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review April 8, 2020 10:20
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize unit test exception
8 participants