Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add link of script in document #2422

Merged
merged 2 commits into from
Mar 19, 2020
Merged

optimize: add link of script in document #2422

merged 2 commits into from
Mar 19, 2020

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #2422 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2422   +/-   ##
==========================================
  Coverage      51.81%   51.81%           
  Complexity      2698     2698           
==========================================
  Files            517      517           
  Lines          16764    16764           
  Branches        2028     2028           
==========================================
+ Hits            8686     8687    +1     
+ Misses          7269     7267    -2     
- Partials         809      810    +1     
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 54.35% <0.00%> (-0.52%) 30.00% <0.00%> (+1.00%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.00% <0.00%> (-0.45%) 72.00% <0.00%> (-1.00%)
...server/store/file/FileTransactionStoreManager.java 57.46% <0.00%> (+0.95%) 29.00% <0.00%> (ø%)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Connection can be opened and positioned accurately.
  2. md format is accurate.

LGTM.

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 26cd699 into apache:develop Mar 19, 2020
@slievrly slievrly added this to the 1.2.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants