Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize contact us and startup log #2440

Merged
merged 3 commits into from
Mar 23, 2020
Merged

optimize: optimize contact us and startup log #2440

merged 3 commits into from
Mar 23, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Mar 23, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize contact us and startup log

  1. The QR code of dingTalk into group is invalid

  2. WeChat group cannot be actively entered into the group and replaced with WeChat official account

  3. Optimize the problem that the output log is null at startup

  4. change the log level when startup delete undolog.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
@apache apache deleted a comment from codecov-io Mar 23, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 23, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #2440 into develop will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2440      +/-   ##
=============================================
- Coverage      51.74%   51.71%   -0.03%     
+ Complexity      2665     2664       -1     
=============================================
  Files            518      518              
  Lines          16805    16809       +4     
  Branches        2031     2031              
=============================================
- Hits            8695     8693       -2     
- Misses          7293     7298       +5     
- Partials         817      818       +1
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 54.08% <0%> (-0.28%) 28 <0> (ø)
...ain/java/io/seata/config/ConfigurationFactory.java 50% <28.57%> (-3.07%) 4 <0> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.5% <0%> (-0.64%) 29% <0%> (-1%)

@xingfudeshi xingfudeshi merged commit 2842e5d into apache:develop Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants