Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: the class registration method of kryo and fst #2445

Merged
merged 11 commits into from
Mar 26, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 24, 2020

Ⅰ. Describe what this PR did

optimize the class registration method of kryo and fst

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 24, 2020

Codecov Report

Merging #2445 into develop will decrease coverage by 0.30%.
The diff coverage is 16.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2445      +/-   ##
=============================================
- Coverage      51.75%   51.45%   -0.31%     
- Complexity      2651     2657       +6     
=============================================
  Files            521      523       +2     
  Lines          16919    16938      +19     
  Branches        2052     2052              
=============================================
- Hits            8757     8716      -41     
- Misses          7331     7391      +60     
  Partials         831      831              
Impacted Files Coverage Δ Complexity Δ
...seata/core/serializer/SerializerClassRegistry.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/io.seata.serializer.fst/FstSerializer.java 100.00% <100.00%> (ø) 3.00 <2.00> (ø)
.../io.seata.serializer.fst/FstSerializerFactory.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
...o/seata/serializer/kryo/KryoSerializerFactory.java 90.90% <100.00%> (-6.28%) 6.00 <0.00> (ø)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize: the way classes are registered optimize: the class registration method of kryo and fst Mar 25, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit e0bff39 into apache:develop Mar 26, 2020
@slievrly slievrly added this to the 1.2.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants