Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix can not get table structure when start #2449

Merged

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix can not get table struct when start.

Ⅱ. Does this pull request fix one issue?

#2342

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #2449 into develop will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2449      +/-   ##
=============================================
+ Coverage      51.43%   51.78%   +0.34%     
+ Complexity      2662     2653       -9     
=============================================
  Files            529      520       -9     
  Lines          16956    16914      -42     
  Branches        2051     2051              
=============================================
+ Hits            8722     8759      +37     
+ Misses          7408     7326      -82     
- Partials         826      829       +3
Impacted Files Coverage Δ Complexity Δ
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <100%> (ø) 34 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/InsertExecutor.java 65.43% <0%> (-4.45%) 39% <0%> (-8%)
...ing/boot/autoconfigure/SeataAutoConfiguration.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ation/datasource/AutoDataSourceProxyRegistrar.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/io.seata.serializer.fst/FstSerializer.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...eata/core/store/db/sql/lock/MysqlLockStoreSql.java
...ion/datasource/SeataAutoDataSourceProxyAdvice.java
...on/datasource/SeataAutoDataSourceProxyCreator.java
...seata/core/serializer/SerializerClassRegistry.java
... and 16 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added the bug label Mar 29, 2020
Copy link
Contributor

@ph3636 ph3636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 5fb92d9 into apache:develop Apr 1, 2020
@l81893521 l81893521 deleted the fix_can_not_get_table_structure_when_start branch April 10, 2020 06:50
@slievrly slievrly added this to the 1.2.0 milestone Apr 14, 2020
@wangliang181230 wangliang181230 added type: bug Category issues or prs related to bug. and removed bug labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants