-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: child module can't execute copyright and checkstyle inspection #2455
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2455 +/- ##
=============================================
+ Coverage 51.27% 51.41% +0.13%
- Complexity 2805 2806 +1
=============================================
Files 553 553
Lines 17671 17691 +20
Branches 2052 2091 +39
=============================================
+ Hits 9061 9096 +35
- Misses 7731 7738 +7
+ Partials 879 857 -22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Agree with @helloworlde
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
maven: optimize copyright and checkstyle check
Because step into the submodule to perform MVN clean install will cause the configuration file to be unavailable, such as
${user.dir}/style/copyright
、${user.dir}/style/seata_checkstyle.xml
. therefore, uncheck the checkstyle and copyright of the development environment and instead check it on github CI/CD.Ⅱ. Does this pull request fix one issue?
fix #2438
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews