Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: child module can't execute copyright and checkstyle inspection #2455

Merged
merged 9 commits into from
Apr 16, 2020
Merged

bugfix: child module can't execute copyright and checkstyle inspection #2455

merged 9 commits into from
Apr 16, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Mar 25, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

maven: optimize copyright and checkstyle check

Because step into the submodule to perform MVN clean install will cause the configuration file to be unavailable, such as ${user.dir}/style/copyright${user.dir}/style/seata_checkstyle.xml . therefore, uncheck the checkstyle and copyright of the development environment and instead check it on github CI/CD.

Ⅱ. Does this pull request fix one issue?

fix #2438

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly changed the title bugfix: child module cannot execute copyright and checkstyle inspection bugfix: child module can‘t execute copyright and checkstyle inspection Mar 25, 2020
@slievrly slievrly changed the title bugfix: child module can‘t execute copyright and checkstyle inspection bugfix: child module can't execute copyright and checkstyle inspection Mar 25, 2020
@zjinlei zjinlei added the bug label Mar 29, 2020
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #2455 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2455      +/-   ##
=============================================
+ Coverage      51.27%   51.41%   +0.13%     
- Complexity      2805     2806       +1     
=============================================
  Files            553      553              
  Lines          17671    17691      +20     
  Branches        2052     2091      +39     
=============================================
+ Hits            9061     9096      +35     
- Misses          7731     7738       +7     
+ Partials         879      857      -22     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.86% <0.00%> (-0.59%) 71.00% <0.00%> (ø%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 13.15% <0.00%> (-0.36%) 2.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 28.00% <0.00%> (-0.23%) 13.00% <0.00%> (ø%)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 10.55% <0.00%> (-0.22%) 4.00% <0.00%> (ø%)
...ing/annotation/GlobalTransactionalInterceptor.java 9.58% <0.00%> (-0.14%) 2.00% <0.00%> (ø%)
...in/java/io/seata/server/session/BranchSession.java 78.10% <0.00%> (+0.07%) 44.00% <0.00%> (ø%)
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <0.00%> (+0.09%) 34.00% <0.00%> (ø%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 64.34% <0.00%> (+0.31%) 25.00% <0.00%> (ø%)
...ain/java/io/seata/config/ConfigurationFactory.java 50.00% <0.00%> (+0.98%) 4.00% <0.00%> (ø%)
...buf/convertor/BranchRollbackResponseConvertor.java 100.00% <0.00%> (+2.94%) 3.00% <0.00%> (ø%)
... and 20 more

@zjinlei zjinlei added this to the 1.2.0 milestone Apr 10, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Agree with @helloworlde

@slievrly slievrly merged commit b7fa6d4 into apache:develop Apr 16, 2020
@hermitcai
Copy link

i am run
mvn clean compile -Dcheckstyle.skip=true
on the root node
image

@wangliang181230 wangliang181230 added type: bug Category issues or prs related to bug. and removed bug labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not do maven build in sub module
8 participants