bugfix: fix encode request error #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2456 +/- ##
=============================================
- Coverage 51.45% 51.41% -0.04%
Complexity 2665 2665
=============================================
Files 529 529
Lines 16956 16975 +19
Branches 2051 2050 -1
=============================================
+ Hits 8724 8727 +3
- Misses 7408 7424 +16
Partials 824 824
|
|
经过周末2天的性能压测修复server端编码异常暂无发现server端编码问题，client端也能正常响应。 |
ph3636
reviewed
Mar 31, 2020
| @@ -303,4 +329,16 @@ public void execute(GlobalReportRequest request, GlobalReportResponse response) | |||
| protected abstract void doGlobalReport(GlobalReportRequest request, GlobalReportResponse response, | |||
| RpcContext rpcContext) throws TransactionException; | |||
|
|
|||
There was a problem hiding this comment.
lack GlobalReportResponse.setGlobalStatus()
Signed-off-by: slievrly <slievrly@163.com>
zjinlei
approved these changes
Apr 7, 2020
wangliang181230
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix encode request error
Ⅱ. Does this pull request fix one issue?
fix #2458
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews