optimize: saga transaction editor enhancements #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxszs
changed the title
l81893521
reviewed
Mar 31, 2020
| @@ -35,6 +35,15 @@ class Page extends React.Component { | |||
| } | |||
|
|
|||
| if (newData !== oldData) { | |||
| // Compensation类型后置连接点去掉箭头 | |||
There was a problem hiding this comment.
Please use English comment instead.
l81893521
reviewed
Mar 31, 2020
| @@ -38,12 +38,24 @@ class WorkSpaceBase extends React.Component { | |||
| const { executeCommand, update } = propsAPI; | |||
|
|
|||
| if (param.action == 'add' && param.item.type == 'edge') { | |||
| // 默认圆角折线 | |||
There was a problem hiding this comment.
Please use English comment instead.
Codecov Report
@@ Coverage Diff @@
## develop #2464 +/- ##
=============================================
- Coverage 51.51% 51.43% -0.08%
+ Complexity 2667 2662 -5
=============================================
Files 523 529 +6
Lines 16944 16956 +12
Branches 2053 2051 -2
=============================================
- Hits 8728 8722 -6
- Misses 7390 7408 +18
Partials 826 826
|
long187
approved these changes
Apr 15, 2020
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The default line is the fillet line
Compensation type post connection point cancel arrow
Node border of substatemachine type is bold
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews