Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: refactor client handle request process logic from server #2477

Merged
merged 33 commits into from
May 18, 2020
Merged

optimize: refactor client handle request process logic from server #2477

merged 33 commits into from
May 18, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Mar 28, 2020 •
edited

Ⅰ. Describe what this PR did

  1. add netty processor, in order to separate the processing business from netty.
  2. add client processor：
    ClientHeartbeatProcessor
    ClientOnResponseProcessor
    RmBranchCommitProcessor
    RmBranchRollbackProcessor
    RmUndoLogProcessor
  3. remove interfaces:
    ClientMessageSender
    RegisterMsgListener
    ClientMessageListener
  4. add RemotingBootstrap interface.

Ⅱ. Does this pull request fix one issue?

refactoring tasks: #2313

III.Processor call flow.

server -> client
image

IV. TODO

  1. add server processor.
  2. refactoring rpc request method.

@objcoding objcoding changed the title optimize: refactoring rpc. optimize: refactoring rpc phase2. Mar 28, 2020
@codecov-io
Copy link

codecov-io commented Mar 28, 2020 •
edited

Codecov Report

Merging #2477 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2477   +/-   ##
==========================================
  Coverage      50.95%   50.95%           
  Complexity      2830     2830           
==========================================
  Files            563      563           
  Lines          18043    18043           
  Branches        2136     2136           
==========================================
  Hits            9193     9193           
  Misses          7980     7980           
  Partials         870      870

@objcoding objcoding mentioned this pull request Mar 30, 2020
Merged
@zjinlei zjinlei added this to the 1.3.0 milestone Apr 10, 2020
@slievrly slievrly self-requested a review April 27, 2020 07:18
@objcoding objcoding changed the title optimize: refactoring rpc phase2. optimize: refactoring rpc phase2 -> add netty processor. May 6, 2020
@objcoding objcoding changed the title optimize: refactoring rpc phase2 -> add netty processor. optimize: refactoring rpc phase2(add netty processor). May 6, 2020
@objcoding objcoding changed the title optimize: refactoring rpc phase2(add netty processor). optimize: add client processor(phase2). May 6, 2020
@objcoding objcoding changed the title optimize: add client processor(phase2). optimize: refactoring rpc phase2(add netty processor). May 6, 2020
@objcoding objcoding changed the title optimize: refactoring rpc phase2(add netty processor). optimize: refactoring rpc phase2(add client processor). May 6, 2020
@slievrly
Copy link
Member

checkstyle

@objcoding
Copy link
Contributor Author

checkstyle

ok.

@funky-eyes
Copy link
Contributor

please check the test case:
StateMachineDBTests.testCompensationAndSubStateMachineAsyncWithLayout:563

@objcoding
Copy link
Contributor Author

testCompensationAndSubStateMachineAsyncWithLayout

Unit tests are OK.

slievrly
slievrly approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@objcoding objcoding requested a review from slievrly May 14, 2020 13:39
@zjinlei zjinlei removed the request for review from slievrly May 14, 2020 15:52
l81893521
l81893521 approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@objcoding objcoding changed the title optimize: refactoring rpc phase2(add client processor). optimize: refactoring client request processing logic. May 18, 2020
@l81893521 l81893521 added the module/core core module label May 18, 2020
@l81893521 l81893521 merged commit c5e5c6f into apache:develop May 18, 2020
@l81893521 l81893521 changed the title optimize: refactoring client request processing logic. optimize: refactor client handle request process logic from server May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

Assignees
No one assigned
Labels
module/core core module
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@objcoding @codecov-io @slievrly @funky-eyes @l81893521 @zjinlei