bugfix: postgresql schema lowerCase #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2479 +/- ##
=============================================
- Coverage 51.45% 51.44% -0.01%
- Complexity 2662 2664 +2
=============================================
Files 529 529
Lines 16952 16956 +4
Branches 2049 2051 +2
=============================================
+ Hits 8722 8723 +1
- Misses 7405 7408 +3
Partials 825 825
|
l81893521
reviewed
Mar 29, 2020
| @@ -102,7 +102,7 @@ private TableMeta resultSetMetaToSchema(DatabaseMetaData dbmd, String tableName) | |||
| * select * from "Sel'ect" | |||
| */ | |||
| if (null != schemaName) { | |||
| schemaName = schemaName.replaceAll("(^\")|(\"$)", ""); | |||
| schemaName = schemaName.replaceAll("(^\")|(\"$)", "").toLowerCase(); | |||
There was a problem hiding this comment.
why if schema name not null, lower case the schema name?
How about the situation like below?
CREATE DATABASE "SeAtA"
There was a problem hiding this comment.
fix:
select * from TEST.test
select * from test.TEST
select * from "Test".test
select * from "Test"."Select"
jaspercloud
changed the title
slievrly
reviewed
Mar 31, 2020
| */ | ||
| if (null != schemaName) { | ||
| schemaName = schemaName.replaceAll("(^\")|(\"$)", ""); | ||
| if (schemaName.startsWith("\"") && schemaName.endsWith("\"")) { | ||
| schemaName = schemaName.replaceAll("(^\")|(\"$)", ""); |
There was a problem hiding this comment.
Can quotes exist between characters?
There was a problem hiding this comment.
It has been confirmed that it may contain special characters.
There was a problem hiding this comment.
support select * from "Te"'st"."Select"
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#2435
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews