Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support: add the max wait configuration for db #2481

Merged
merged 2 commits into from
Mar 31, 2020
Merged

support: add the max wait configuration for db #2481

merged 2 commits into from
Mar 31, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 29, 2020 •
edited

Ⅰ. Describe what this PR did

increase max wait parameter configuration

Ⅱ. Does this pull request fix one issue?

#2482

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title support: increase max wait parameter configuration support: add the max wait configuration for db Mar 29, 2020
@codecov-io
Copy link

codecov-io commented Mar 29, 2020 •
edited

Codecov Report

Merging #2481 into develop will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2481      +/-   ##
=============================================
- Coverage      51.47%   51.32%   -0.15%     
  Complexity      2659     2659              
=============================================
  Files            523      523              
  Lines          16938    16940       +2     
  Branches        2052     2023      -29     
=============================================
- Hits            8718     8694      -24     
- Misses          7391     7394       +3     
- Partials         829      852      +23
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...io/seata/server/store/DbcpDataSourceGenerator.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...o/seata/server/store/DruidDataSourceGenerator.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0%> (-9.53%) 3% <0%> (ø)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
... and 16 more

slievrly
slievrly approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightClouds917
Copy link
Contributor

add this to the script @a364176773

@funky-eyes
Copy link
Contributor Author

add this to the script @a364176773

ok

@funky-eyes
Copy link
Contributor Author

add this to the script @a364176773

PTAL

l81893521
l81893521 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightClouds917
Copy link
Contributor

LGTM

@l81893521 l81893521 merged commit 5767edb into apache:develop Mar 31, 2020
zjinlei
zjinlei approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.2.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@zjinlei zjinlei zjinlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@funky-eyes @codecov-io @lightClouds917 @l81893521 @slievrly @zjinlei