-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix RpcContext.addResource when resource is null #2490
Conversation
…,should do nothing,instead of reset resourceSets
Codecov Report
@@ Coverage Diff @@
## develop #2490 +/- ##
=============================================
- Coverage 51.39% 51.36% -0.04%
Complexity 2664 2664
=============================================
Files 529 529
Lines 16981 16983 +2
Branches 2050 2051 +1
=============================================
- Hits 8728 8723 -5
- Misses 7426 7432 +6
- Partials 827 828 +1
|
please git relation github user.name and user.email |
I made sure that this method is only used in UT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bugfix: fix RpcContext.addResource when resource is null (seata#2490)
RpcContext.addResource(String resource),when resource is blank,should do nothing,instead of reset resourceSets
Ⅰ. Describe what this PR did
the original code is
obviously, there is a bug
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews