-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add methods to reduce redundant code #2494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format the code according to the p3c specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Zh1Cheung please format the code you modify,there are some code style check not passed. |
|
remove the first blank line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I found the XML file. It locates at #2510 (comment) is my reply. |
Codecov Report
@@ Coverage Diff @@
## develop #2494 +/- ##
=============================================
- Coverage 51.07% 50.93% -0.14%
+ Complexity 2766 2764 -2
=============================================
Files 550 550
Lines 17525 17521 -4
Branches 2063 2032 -31
=============================================
- Hits 8951 8925 -26
+ Misses 7734 7732 -2
- Partials 840 864 +24 |
Thanks,I ran xx before (at that time my first line was not a blank line), after the build was successful, I checked the result file and found no errors, just
Later, I have not noticed this problem (the first line at this time is a blank line), I always thought it was a problem of maven dependency In addition, I want to know if I will continue to work under this pr or create a new pr when I want to work on code optimization ? |
Thanks, I found this file later |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
xxx
Ⅲ. Why don't you add test cases (unit test/integration test)?
xxx
Ⅳ. Describe how to verify it
xxx
Ⅴ. Special notes for reviews