-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix bug of session store path value judgment #2505
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2505 +/- ##
=============================================
- Coverage 51.45% 51.43% -0.02%
+ Complexity 2664 2662 -2
=============================================
Files 529 529
Lines 16956 16956
Branches 2051 2051
=============================================
- Hits 8724 8722 -2
Misses 7408 7408
- Partials 824 826 +2
|
@l81893521 @zjinlei @ggndnn PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jsbxyyx PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix bug of session store path value judgment
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews