Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix bug of session store path value judgment #2505

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Apr 3, 2020

Ⅰ. Describe what this PR did

fix bug of session store path value judgment

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #2505 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2505      +/-   ##
=============================================
- Coverage      51.45%   51.43%   -0.02%     
+ Complexity      2664     2662       -2     
=============================================
  Files            529      529              
  Lines          16956    16956              
  Branches        2051     2051              
=============================================
- Hits            8724     8722       -2     
  Misses          7408     7408              
- Partials         824      826       +2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/SessionHolder.java 56.62% <0.00%> (ø) 18.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.08% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 85.32% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

@funky-eyes
Copy link
Contributor Author

@l81893521 @zjinlei @ggndnn PTAL

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor Author

@jsbxyyx PTAL

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title fixbug: of sessionStorePath judgment fixbug: of session store path judgment Apr 3, 2020
@funky-eyes funky-eyes changed the title fixbug: of session store path judgment fixbug: fix bugof session store path judgment Apr 3, 2020
@funky-eyes funky-eyes changed the title fixbug: fix bugof session store path judgment fixbug: fix bug of session store path value judgment Apr 3, 2020
@funky-eyes funky-eyes changed the title fixbug: fix bug of session store path value judgment bugfix: of session store path value judgment Apr 3, 2020
@funky-eyes funky-eyes changed the title bugfix: of session store path value judgment bugfix: fix bug of session store path value judgment Apr 3, 2020
@funky-eyes funky-eyes requested a review from slievrly April 3, 2020 05:36
@slievrly slievrly merged commit 2c83e0b into apache:develop Apr 3, 2020
@slievrly slievrly added this to the 1.2.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants