feature: support for undo full data columns on update operate #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
zjinlei
reviewed
Apr 6, 2020
| for (String updateColumn : updateColumns) { | ||
| selectSQLJoin.add(updateColumn); | ||
| for (String column : tableMeta.getAllColumns().keySet()) { | ||
| selectSQLJoin.add(column); |
There was a problem hiding this comment.
Columns from tableMeta, need to deal with keyword
|
|
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2509 +/- ##
=============================================
- Coverage 51.24% 51.20% -0.04%
Complexity 2819 2819
=============================================
Files 556 556
Lines 17807 17829 +22
Branches 2102 2109 +7
=============================================
+ Hits 9125 9130 +5
- Misses 7820 7833 +13
- Partials 862 866 +4
|
|
Whether to add the enable the function flag? |
slievrly
changed the title
Signed-off-by: slievrly <slievrly@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix update only care about update columns
Ⅱ. Does this pull request fix one issue?
fix #2502 #2541
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews