Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: abnormal global transactions, output logs according to frequency #2523

Merged
merged 10 commits into from
Apr 14, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize log output when rm client disconnects abnormally

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #2523 into develop will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2523      +/-   ##
=============================================
- Coverage      51.45%   51.42%   -0.04%     
+ Complexity      2808     2805       -3     
=============================================
  Files            553      553              
  Lines          17691    17699       +8     
  Branches        2088     2089       +1     
=============================================
- Hits            9103     9101       -2     
- Misses          7735     7743       +8     
- Partials         853      855       +2     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/core/logger/StackTraceLogger.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/io/seata/core/rpc/netty/RpcServer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/io/seata/server/coordinator/DefaultCore.java 54.32% <0.00%> (-0.68%) 23.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.50% <0.00%> (-0.50%) 28.00% <0.00%> (-2.00%)
...in/java/io/seata/server/session/GlobalSession.java 84.86% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

@zjinlei zjinlei added this to the 1.2.0 milestone Apr 10, 2020
core/src/main/java/io/seata/core/rpc/netty/RpcServer.java Outdated Show resolved Hide resolved

StackTraceLogger.warn(LOGGER,
new RuntimeException("rm client is not connected. dbkey:" + resourceId + ",clientId:" + clientId),
"rm client is not connected. dbkey: {},clientId: {}", new String[] {resourceId, clientId});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this logic continue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @slievrly

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize: optimize log output when rm client disconnects abnormally optimize: when doing global transaction commit or rollback exceptions, the log outputs based on probability Apr 13, 2020
@funky-eyes funky-eyes changed the title optimize: when doing global transaction commit or rollback exceptions, the log outputs based on probability optimize: abnormal global transactions, output logs according to frequency Apr 14, 2020
@slievrly slievrly merged commit bb07eec into apache:develop Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants