-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: abnormal global transactions, output logs according to frequency #2523
optimize: abnormal global transactions, output logs according to frequency #2523
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2523 +/- ##
=============================================
- Coverage 51.45% 51.42% -0.04%
+ Complexity 2808 2805 -3
=============================================
Files 553 553
Lines 17691 17699 +8
Branches 2088 2089 +1
=============================================
- Hits 9103 9101 -2
- Misses 7735 7743 +8
- Partials 853 855 +2
|
|
||
StackTraceLogger.warn(LOGGER, | ||
new RuntimeException("rm client is not connected. dbkey:" + resourceId + ",clientId:" + clientId), | ||
"rm client is not connected. dbkey: {},clientId: {}", new String[] {resourceId, clientId}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this logic continue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL @slievrly
df6b8ce
to
4ae665f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize log output when rm client disconnects abnormally
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews