bugfix: registration service configuration missing and inconsistent #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2524 +/- ##
=============================================
+ Coverage 51.05% 51.06% +0.01%
- Complexity 2762 2766 +4
=============================================
Files 550 550
Lines 17525 17529 +4
Branches 2064 2064
=============================================
+ Hits 8947 8951 +4
Misses 7735 7735
Partials 843 843
|
|
server/src/main/resources/registry.conf are the password and timeout configuration missing in the file? need to add it? |
zjinlei
approved these changes
Apr 11, 2020
|
explanation: the local clusterName variable needs to be used here, because the configuration properties of the cluster may not exist on the client side but only on the server side. |
slievrly
changed the title
done |
|
retry ci |
ph3636
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
inconsistent Redis and Etcd3 publish and subscribe service
SOFA property name setting error
Nacos and SOFA missing client configuration
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews