Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove use connPool. #2530

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

remove use connPool, Because apache object-pool is already used.

@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #2530 into develop will increase coverage by 0.12%.
The diff coverage is 12.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2530      +/-   ##
=============================================
+ Coverage      50.94%   51.06%   +0.12%     
- Complexity      2763     2764       +1     
=============================================
  Files            551      550       -1     
  Lines          17569    17525      -44     
  Branches        2063     2064       +1     
=============================================
- Hits            8950     8949       -1     
+ Misses          7775     7735      -40     
+ Partials         844      841       -3     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java 34.84% <0.00%> (-1.59%) 6.00 <0.00> (ø)
...ava/io/seata/core/rpc/netty/NettyClientConfig.java 45.31% <ø> (-1.66%) 22.00 <0.00> (-1.00)
...va/io/seata/core/rpc/netty/RpcClientBootstrap.java 42.25% <16.66%> (+8.54%) 6.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 85.32% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.00% <0.00%> (+0.50%) 29.00% <0.00%> (+1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit de4a6ec into apache:develop Apr 10, 2020
@slievrly slievrly added this to the 1.2.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants