optimize: refactoring rpc request method and rpc interface. #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
l81893521
reviewed
Jul 7, 2020
l81893521
reviewed
Jul 7, 2020
l81893521
reviewed
Jul 8, 2020
slievrly
reviewed
Jul 8, 2020
core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 8, 2020
core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 8, 2020
| */ | ||
| Object sendMsgWithResponse(String serverAddress, Object msg, long timeout) throws TimeoutException; | ||
| Object sendSyncRequest(Channel channel, Object msg) throws TimeoutException; |
There was a problem hiding this comment.
should there be a channel parameter?
There was a problem hiding this comment.
At that time, why the channel invaded the RemotingClient interface was also a helpless choice, because when called in many places, the various parameters were not uniform, it was difficult to remove the dependency of the channel. At that time, my idea was,
- RemotingClient as a top-level interface, when other rpc types are added in the future, their interfaces can be added to this top-level interface
- Remove the netty-related dependencies and make a RemotingClient that is truly irrelevant to the specific rpc type
In the end I chose the first and easiest method to refactor.
I would like to add a pr later to improve it.
slievrly
reviewed
Jul 8, 2020
core/src/main/java/io/seata/core/rpc/netty/NettyClientBootstrap.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 8, 2020
core/src/main/java/io/seata/core/rpc/netty/NettyRemotingServer.java
Outdated
Show resolved
Hide resolved
l81893521
reviewed
Jul 10, 2020
core/src/main/java/io/seata/core/rpc/processor/client/RmBranchRollbackProcessor.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 12, 2020
core/src/main/java/io/seata/core/rpc/processor/server/RegRmProcessor.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 12, 2020
core/src/main/java/io/seata/core/rpc/processor/server/RegTmProcessor.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jul 12, 2020
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingServer.java
Show resolved
Hide resolved
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
this pr base on phase3:#2486
refactoring rpc request method:
(1) AbstractRemoting
Object sendSync(Channel channel, RpcMessage rpcMessage, long timeoutMillis) throws TimeoutException
void sendAsync(Channel channel, RpcMessage rpcMessage)
(2) RemotingClient
Object sendSyncRequest(Object msg) throws TimeoutException;
Object sendSyncRequest(Channel channel, Object msg) throws TimeoutException;
void sendAsyncRequest(Channel channel, Object msg);
void sendAsyncResponse(String serverAddress, RpcMessage rpcMessage, Object msg);
(3) RemotingServer
Object sendSyncRequest(String resourceId, String clientId, Object msg) throws TimeoutException;
Object sendSyncRequest(Channel channel, Object msg) throws TimeoutException;
void sendAsyncRequest(Channel channel, Object msg);
void sendAsyncResponse(RpcMessage rpcMessage, Channel channel, Object msg);
Name optimization and class classification.
remove AbstractNettyRemotingSever.
Ⅱ. Does this pull request fix one issue?
refactoring tasks: #2313
ⅡⅠ. Method call
Two fixed rpc communication methods: sendSync and sendAsync method, client and server can freely extend the request method, and finally send messages through sendSync and sendAsync method.
ⅠV. Remote service interface relationship