bugfix: ApplicationKeeper ShutdownHook signal invalid. #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change method keep use Condition.await
Codecov Report
@@ Coverage Diff @@
## develop #2543 +/- ##
=============================================
- Coverage 51.18% 51.17% -0.02%
+ Complexity 2807 2804 -3
=============================================
Files 554 554
Lines 17776 17776
Branches 2101 2101
=============================================
- Hits 9099 9097 -2
Misses 7819 7819
- Partials 858 860 +2
|
slievrly
reviewed
Apr 14, 2020
|
the rest LGTM. |
jsbxyyx
changed the title
xiaowan
pushed a commit
to xiaowan/seata
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change method keep use Condition.await
Ⅰ. Describe what this PR did
change method keep use Condition.await
Ⅱ. Does this pull request fix one issue?
fixes #2542
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews