optimize: add some notes about using scripts #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See if you can remove unnecessary configuration from conf.txt? |
slievrly
reviewed
Apr 15, 2020
script/config-center/README.md
Outdated
| | server | client | | ||
| | ------------------------ | -------------------------------------- | | ||
| | store.mode | service.vgroupMapping.my_test_tx_group | | ||
| | store.db.driverClassName | service.default.grouplist | |
There was a problem hiding this comment.
service.default.grouplist only used in registry.type=file mode
There was a problem hiding this comment.
service.default.grouplistonly used inregistry.type=filemode
PTAL
Codecov Report
@@ Coverage Diff @@
## develop #2553 +/- ##
=============================================
+ Coverage 51.40% 51.41% +0.01%
- Complexity 2805 2807 +2
=============================================
Files 553 553
Lines 17698 17698
Branches 2093 2093
=============================================
+ Hits 9097 9099 +2
Misses 7742 7742
+ Partials 859 857 -2
|
zjinlei
reviewed
Apr 16, 2020
script/config-center/README.md
Outdated
| @@ -1,6 +1,19 @@ | |||
| # Script usage demo | |||
|  | |||
funky-eyes
changed the title
|
@a364176773 need a brief description of pr title. |
funky-eyes
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
supplementary configuration note information
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews