Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: add zk serializer. #2554

Merged
merged 21 commits into from
Apr 24, 2020
Merged

bugfix: add zk serializer. #2554

merged 21 commits into from
Apr 24, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Apr 15, 2020 •
edited

Ⅰ. Describe what this PR did

add zk serializer.

Ⅱ. Does this pull request fix one issue?

fixes #2337

@slievrly slievrly added this to the 1.3.0 milestone Apr 15, 2020
@funky-eyes
Copy link
Contributor

server/src/main/resources/registry.conf need to add?

@jsbxyyx jsbxyyx mentioned this pull request Apr 15, 2020
Closed
1 task
@objcoding
Copy link
Contributor Author

registry.c

Yes, it needs to be added here.

@codecov-io
Copy link

codecov-io commented Apr 16, 2020 •
edited

Codecov Report

Merging #2554 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2554      +/-   ##
=============================================
- Coverage      51.17%   51.03%   -0.14%     
  Complexity      2804     2804              
=============================================
  Files            554      554              
  Lines          17772    17775       +3     
  Branches        2099     2072      -27     
=============================================
- Hits            9094     9072      -22     
- Misses          7819     7820       +1     
- Partials         859      883      +24
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchCommitRequestConvertor.java 95.83% <0.00%> (-4.17%) 3.00% <0.00%> (ø%)
... and 15 more

@objcoding objcoding changed the title feature: add zk serializer. bugfix: add zk serializer. Apr 16, 2020
jsbxyyx
jsbxyyx approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

slievrly
slievrly approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 141891e into apache:develop Apr 24, 2020
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
@objcoding
bugfix: add zk serializer. (apache#2554)
db443a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 left review comments

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@jsbxyyx jsbxyyx jsbxyyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

seata server读取zookeeper配置异常
8 participants
@objcoding @funky-eyes @codecov-io @l81893521 @slievrly @xingfudeshi @jsbxyyx @zjinlei