Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize config and server module log #2558

Merged
merged 5 commits into from
Apr 15, 2020
Merged

optimize: optimize config and server module log #2558

merged 5 commits into from
Apr 15, 2020

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize config and server module log

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.2.0 milestone Apr 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #2558 into develop will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2558      +/-   ##
=============================================
- Coverage      51.43%   51.41%   -0.02%     
+ Complexity      2807     2805       -2     
=============================================
  Files            553      553              
  Lines          17699    17691       -8     
  Branches        2089     2091       +2     
=============================================
- Hits            9103     9096       -7     
+ Misses          7743     7738       -5     
- Partials         853      857       +4     
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/seata/config/ConfigurationFactory.java 50.00% <0.00%> (ø) 4.00 <0.00> (ø)
...c/main/java/io/seata/config/FileConfiguration.java 34.84% <0.00%> (ø) 6.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <33.33%> (-0.37%) 28.00 <2.00> (-1.00)
...java/io/seata/server/coordinator/AbstractCore.java 55.29% <37.50%> (-0.66%) 12.00 <0.00> (ø)
.../java/io/seata/server/coordinator/DefaultCore.java 54.08% <50.00%> (-0.24%) 23.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.86% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit e4f7b6c into apache:develop Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants