Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: keep the same logic of get table meta #2561

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Keep the same logic of get table meta. And make it more readable.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #2561 into develop will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2561      +/-   ##
=============================================
- Coverage      51.18%   51.17%   -0.02%     
+ Complexity      2806     2804       -2     
=============================================
  Files            554      554              
  Lines          17775    17772       -3     
  Branches        2101     2099       -2     
=============================================
- Hits            9098     9094       -4     
  Misses          7819     7819              
- Partials         858      859       +1     
Impacted Files Coverage Δ Complexity Δ
...asource/sql/struct/cache/OracleTableMetaCache.java 75.90% <0.00%> (ø) 9.00 <0.00> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 76.40% <33.33%> (+0.31%) 10.00 <1.00> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 82.55% <66.66%> (ø) 10.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.3.0 milestone Apr 21, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 422aa13 into apache:develop Apr 24, 2020
@l81893521 l81893521 deleted the keep_same_logic_of_get_table_meta branch April 27, 2020 01:31
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants