Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support for transaction annotations on classes #2565

Merged
merged 7 commits into from
Apr 23, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Apr 16, 2020

Ⅰ. Describe what this PR did

support for transaction annotations on classes

Ⅱ. Does this pull request fix one issue?

fix #2562

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #2565 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2565      +/-   ##
=============================================
- Coverage      51.19%   51.18%   -0.01%     
  Complexity      2806     2806              
=============================================
  Files            554      554              
  Lines          17774    17776       +2     
  Branches        2101     2101              
=============================================
  Hits            9099     9099              
- Misses          7817     7819       +2     
  Partials         858      858              
Impacted Files Coverage Δ Complexity Δ
...ing/annotation/GlobalTransactionalInterceptor.java 9.33% <0.00%> (-0.26%) 2.00 <0.00> (ø)

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei added this to the 1.3.0 milestone Apr 21, 2020
@funky-eyes funky-eyes requested a review from jsbxyyx April 22, 2020 02:31
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 54d37ee into apache:develop Apr 23, 2020
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望@GlobalTransactional支持ElementType.TYPE
5 participants