-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support GlobalTransactionInterceptor expression #2568
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2568 +/- ##
=============================================
- Coverage 50.86% 50.83% -0.04%
- Complexity 2811 2815 +4
=============================================
Files 557 560 +3
Lines 17905 17912 +7
Branches 2124 2112 -12
=============================================
- Hits 9108 9106 -2
- Misses 7930 7942 +12
+ Partials 867 864 -3
|
本机采用切面集成at模式测试正常没有问题,测试服务器跑p跑了几个小时运行正常。 |
Codecov Report
@@ Coverage Diff @@
## develop #2568 +/- ##
=============================================
+ Coverage 40.71% 40.76% +0.04%
- Complexity 3042 3052 +10
=============================================
Files 679 681 +2
Lines 22779 22853 +74
Branches 2841 2842 +1
=============================================
+ Hits 9275 9315 +40
- Misses 12634 12667 +33
- Partials 870 871 +1
|
spring/src/main/java/io/seata/spring/util/GlobalTransactionalCheck.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/util/GlobalTransactionalCheck.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/util/GlobalTransactionalCheck.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/HandleGlobalTransaction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AspectTransactionalInterceptor bean( configuration bean)
is necessary to put it in seata-spring-boot-starter?
ignore it. if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
support aspect programming
Ⅱ. Does this pull request fix one issue?
fix #2563 #527
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews