optimize: replace Random by ThreadLocalRandom in RandomLoadBalance #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2573 +/- ##
==========================================
Coverage 51.03% 51.04%
- Complexity 2804 2806 +2
==========================================
Files 554 554
Lines 17756 17755 -1
Branches 2062 2062
==========================================
+ Hits 9062 9063 +1
Misses 7812 7812
+ Partials 882 880 -2
|
|
please help to see if other classes need to be processed |
Already checked, no more classes need to be processed. |
|
please try again for ci @slievrly |
xiaowan
pushed a commit
to xiaowan/seata
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadLocalRandom will achieve less contention.
Replace Random by ThreadLocalRandom in RandomLoadBalance，refer to the implement of RandomLoadBalance in dubbo.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
test case LoadBalanceTest already exist.
Ⅳ. Describe how to verify it
test case LoadBalanceTest already exist.
Ⅴ. Special notes for reviews