bugfix: fix executeBatch can not get targetSql in Statement mode

[HankDevelop]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix bug #2537

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

in seata 1.1.0 addBatch could invoke only once。
if use jdbcTemplate.batchUpdate(String...sql), Only supports one SQL

[zjinlei]

If the business sql has ";", the spliced sql will be wrong.
But the business side can handle it, and it can be changed here or not.

[HankDevelop]

There may be problems using split characters here. The best strategy is to store sql in List

[zjinlei]

There may be problems using split characters here. The best strategy is to store sql in List

Released soon, no major changes.

[zjinlei]

LGTM
test batchUpdate(sql1,sql2,sql3) well, unsupport batchUpdate(sql1;sql2;sql3).

[zjinlei]

Test case failed, because "targetSQL = null;", but I think you are right to add it.
[ERROR] StatementProxyTest.testGetTargetSQL:105 expected: not
[ERROR] Tests run: 218, Failures: 1, Errors: 0, Skipped: 0

[l81893521]

Please fix the unit test at io.seata.rm.datasource.StatementProxyTest#testGetTargetSQL

[HankDevelop]

I will fix it now ----- 原始邮件 ----- 发件人：will <notifications@github.com> 收件人：seata/seata <seata@noreply.github.com> 抄送人：HankDevelop <kuliuht@sina.com>, Author <author@noreply.github.com> 主题：Re: [seata/seata] fix bug#2537 jdbcTemplate batchUpdate can not get targetSql (#2575) 日期：2020年04月19日 21点13分 @l81893521 commented on this pull request. Please fix the unit test at io.seata.rm.datasource.StatementProxyTest#testGetTargetSQL &mdash; You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[l81893521]

@HankDevelop Thanks. We will test it later.

[codecov-io]

Codecov Report

Merging #2575 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2575      +/-   ##
=============================================
- Coverage      51.19%   51.18%   -0.02%     
+ Complexity      2806     2804       -2     
=============================================
  Files            554      554              
  Lines          17768    17774       +6     
  Branches        2101     2101              
=============================================
  Hits            9097     9097              
- Misses          7814     7817       +3     
- Partials         857      860       +3     

Impacted Files	Coverage Δ	Complexity Δ
...io/seata/rm/datasource/AbstractStatementProxy.java	85.00% <100.00%> (-3.14%)	34.00 <0.00> (-1.00)
...in/java/io/seata/rm/datasource/StatementProxy.java	100.00% <100.00%> (ø)	24.00 <2.00> (+2.00)
...torage/file/store/FileTransactionStoreManager.java	56.59% <0.00%> (-0.65%)	28.00% <0.00%> (-1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java	54.63% <0.00%> (-0.52%)	28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java	83.71% <0.00%> (-0.46%)	71.00% <0.00%> (-1.00%)

[slievrly]

       Object[] objParam1 = new Object[] {100, 807};
        Object[] objParam2 = new Object[] {100, 808};
        List<Object[]> params = new ArrayList<>();
        params.add(objParam1);
        params.add(objParam2);
        jdbcTemplate.batchUpdate("update storage_tbl set count=? where id=?", params);

[l81893521]

Test passed.

jdbcTemplate.update("update seata.`account_tbl` set money = money - ? where user_id = ?;update seata.`account_tbl` set money = money - ? where user_id = ?;",
                new Object[] {money, userIds[0], money, userIds[1]});

jdbcTemplate.batchUpdate(
                "update account_tbl set money = money - " + money + ", sex = 1 where user_id = \"" + userIds[0] + "\"",
                "update account_tbl set money = money - " + money + ", sex = 1 where user_id = \"" + userIds[1] + "\"");

jdbcTemplate.batchUpdate("update account_tbl set money = money - ?, sex = 1 where user_id = ?", new BatchPreparedStatementSetter() {
            @Override
            public void setValues(PreparedStatement ps, int i) throws SQLException {
                String userId = userIds[i];
                ps.setInt(1, money);
                ps.setString(2, userId);
            }

            @Override
            public int getBatchSize() {
                return userIds.length;
            }
        });

[l81893521]

LGTM. Please wait @slievrly review

[slievrly]

LGTM, #2575 (comment)