feature: StateHandlerInterceptor and StateRouterInterceptor support SPI #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2584 +/- ##
=============================================
- Coverage 51.19% 51.04% -0.15%
+ Complexity 2806 2804 -2
=============================================
Files 554 554
Lines 17774 17774
Branches 2101 2072 -29
=============================================
- Hits 9099 9073 -26
- Misses 7817 7818 +1
- Partials 858 883 +25 |
Codecov Report
@@ Coverage Diff @@
## develop #2584 +/- ##
==========================================
Coverage 50.18% 50.18%
- Complexity 2919 2921 +2
==========================================
Files 578 578
Lines 18724 18724
Branches 2253 2252 -1
==========================================
Hits 9396 9396
Misses 8396 8396
Partials 932 932
|
slievrly
reviewed
Jun 17, 2020
| @Override | ||
| public void addInterceptor(StateHandlerInterceptor interceptor) { | ||
| if (interceptors != null && !interceptors.contains(interceptor)) { | ||
| interceptors.add(interceptor); |
There was a problem hiding this comment.
Whether need to sort the interceptor?
There was a problem hiding this comment.
Sorting has been done in EnhancedServiceLoader.findAllExtensionDefinition method
slievrly
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Optimize: Saga StateHandlerInterceptor and StateRouterInterceptor support SPI
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
see seata/test/src/test/resources/META-INF/services