Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: judging xid status to avoid repeated processing #2597

Merged
merged 17 commits into from
Sep 15, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Apr 22, 2020

Ⅰ. Describe what this PR did

judging xid status to avoid repeated processing
transactionPropagationIntercepter with seataHandlerInterceptor conflict

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

relevance: alibaba/spring-cloud-alibaba#1352

@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #2597 into develop will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2597      +/-   ##
=============================================
- Coverage      50.91%   50.78%   -0.14%     
- Complexity      2814     2815       +1     
=============================================
  Files            558      558              
  Lines          17936    17936              
  Branches        2127     2097      -30     
=============================================
- Hits            9132     9108      -24     
- Misses          7934     7935       +1     
- Partials         870      893      +23     
Impacted Files Coverage Δ Complexity Δ
...ration/http/TransactionPropagationIntercepter.java 42.85% <0.00%> (-3.30%) 4.00 <0.00> (+1.00) ⬇️
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
... and 14 more

@funky-eyes funky-eyes closed this Apr 26, 2020
@funky-eyes funky-eyes reopened this Apr 26, 2020
@funky-eyes funky-eyes closed this May 13, 2020
@funky-eyes funky-eyes reopened this May 13, 2020
@l81893521 l81893521 added the module/integration integration module label May 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #2597 into develop will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2597   +/-   ##
==========================================
  Coverage      50.60%   50.60%           
- Complexity      3101     3102    +1     
==========================================
  Files            599      599           
  Lines          19498    19499    +1     
  Branches        2404     2404           
==========================================
+ Hits            9866     9867    +1     
  Misses          8641     8641           
  Partials         991      991           
Impacted Files Coverage Δ Complexity Δ
...ration/http/TransactionPropagationIntercepter.java 42.85% <0.00%> (-3.30%) 4.00 <0.00> (+1.00) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 82.43% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.41% <0.00%> (+0.64%) 29.00% <0.00%> (+1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.4.0 milestone Sep 9, 2020
@funky-eyes
Copy link
Contributor Author

@jsbxyyx @l81893521 PTAL

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 8a0b49a into apache:develop Sep 15, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/integration integration module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants