Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: can not get generated keys value. #2603

Merged
merged 10 commits into from
May 26, 2020
Merged

bugfix: can not get generated keys value. #2603

merged 10 commits into from
May 26, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Apr 23, 2020

Ⅰ. Describe what this PR did

fix: oracle and postgresql insert executor after not get generated keys value.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #2603 into develop will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2603      +/-   ##
=============================================
- Coverage      50.91%   50.79%   -0.12%     
+ Complexity      2815     2811       -4     
=============================================
  Files            558      558              
  Lines          17941    17936       -5     
  Branches        2129     2124       -5     
=============================================
- Hits            9134     9111      -23     
- Misses          7938     7957      +19     
+ Partials         869      868       -1     
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/InsertExecutor.java 61.87% <33.33%> (-1.40%) 45.00 <1.00> (ø)
...io/seata/rm/datasource/AbstractStatementProxy.java 83.07% <66.66%> (-1.93%) 34.00 <1.00> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
...ta/server/storage/db/lock/DataBaseLockManager.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...o/seata/server/store/HikariDataSourceProvider.java
.../io/seata/server/store/DbcpDataSourceProvider.java
...io/seata/server/store/DruidDataSourceProvider.java
...eata/core/store/db/AbstractDataSourceProvider.java
.../seata/server/store/HikariDataSourceGenerator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...o/seata/server/store/DruidDataSourceGenerator.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 6 more

@jsbxyyx jsbxyyx closed this Apr 24, 2020
@jsbxyyx jsbxyyx reopened this Apr 24, 2020
@zjinlei zjinlei added this to the 1.3.0 milestone May 1, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added the module/rm-datasource rm-datasource module label May 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #2603 into develop will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2603      +/-   ##
=============================================
- Coverage      51.13%   51.12%   -0.01%     
+ Complexity      2849     2847       -2     
=============================================
  Files            566      566              
  Lines          18077    18086       +9     
  Branches        2142     2142              
=============================================
+ Hits            9243     9246       +3     
- Misses          7945     7950       +5     
- Partials         889      890       +1     
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 69.40% <20.00%> (-2.14%) 38.00 <1.00> (ø)
...io/seata/rm/datasource/AbstractStatementProxy.java 83.07% <66.66%> (-1.93%) 34.00 <1.00> (ø)
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 78.78% <100.00%> (ø) 11.00 <0.00> (ø)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 476416a into apache:develop May 26, 2020
@jsbxyyx jsbxyyx deleted the fix_can_not_get_generated_keys branch May 26, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants