-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: insert check pkvalue support. #2607
optimize: insert check pkvalue support. #2607
Conversation
…e_insert_pkvalue_support
Codecov Report
@@ Coverage Diff @@
## develop #2607 +/- ##
=============================================
+ Coverage 50.81% 50.83% +0.01%
- Complexity 2813 2847 +34
=============================================
Files 558 558
Lines 17927 17952 +25
Branches 2124 2133 +9
=============================================
+ Hits 9110 9126 +16
- Misses 7952 7956 +4
- Partials 865 870 +5
|
// support statement: // not support |
…e_insert_pkvalue_support # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/InsertExecutor.java # rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
Codecov Report
@@ Coverage Diff @@
## develop #2607 +/- ##
=============================================
+ Coverage 50.47% 50.50% +0.03%
- Complexity 2889 2921 +32
=============================================
Files 572 572
Lines 18591 18610 +19
Branches 2231 2240 +9
=============================================
+ Hits 9383 9399 +16
Misses 8285 8285
- Partials 923 926 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize insert executor check pkvalues.
preparedstatement mode:
support multi sequeunce, default, sql method.
Ⅱ. Does this pull request fix one issue?
fixes: #2485
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews