Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: nacos-script adapt to nacos 1.2 on permission control. #2610

Merged
merged 4 commits into from
Apr 27, 2020
Merged

bugfix: nacos-script adapt to nacos 1.2 on permission control. #2610

merged 4 commits into from
Apr 27, 2020

Conversation

objcoding
Copy link
Contributor

@objcoding objcoding commented Apr 24, 2020 •
edited

Ⅰ. Describe what this PR did

Adapt to nacos 1.2 on permission control.

Ⅱ. Does this pull request fix one issue?

fixes #2612

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 24, 2020 •
edited

Codecov Report

Merging #2610 into develop will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2610      +/-   ##
=============================================
+ Coverage      51.06%   51.20%   +0.14%     
  Complexity      2810     2810              
=============================================
  Files            554      554              
  Lines          17774    17774              
  Branches        2071     2100      +29     
=============================================
+ Hits            9077     9102      +25     
+ Misses          7813     7812       -1     
+ Partials         884      860      -24
Impacted Files Coverage Δ Complexity Δ
...a/server/storage/db/store/LogStoreDataBaseDAO.java 71.76% <0.00%> (+0.33%) 34.00% <0.00%> (ø%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (ø%)
...buf/convertor/BranchRollbackResponseConvertor.java 100.00% <0.00%> (+2.94%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchCommitResponseConvertor.java 100.00% <0.00%> (+3.03%) 3.00% <0.00%> (ø%)
...buf/convertor/GlobalRollbackResponseConvertor.java 100.00% <0.00%> (+3.22%) 3.00% <0.00%> (ø%)
...tobuf/convertor/GlobalCommitResponseConvertor.java 100.00% <0.00%> (+3.33%) 3.00% <0.00%> (ø%)
...tobuf/convertor/GlobalStatusResponseConvertor.java 100.00% <0.00%> (+3.33%) 3.00% <0.00%> (ø%)
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0.00%> (+3.44%) 3.00% <0.00%> (ø%)
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0.00%> (+3.44%) 3.00% <0.00%> (ø%)
...uf/convertor/GlobalLockQueryResponseConvertor.java 100.00% <0.00%> (+3.84%) 3.00% <0.00%> (ø%)
... and 13 more

@objcoding objcoding changed the title feature: nacos-script add permission upload. feature: nacos-script adapt to nacos 1.2 on permission control. Apr 24, 2020
@objcoding objcoding changed the title feature: nacos-script adapt to nacos 1.2 on permission control. bugfix: nacos-script adapt to nacos 1.2 on permission control. Apr 26, 2020
@objcoding
Copy link
Contributor Author

image
Use nacos 1.1.3 version to execute the script, no error is reported, which can be seen to be compatible with the old version

slievrly
slievrly approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes
funky-eyes approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

l81893521
l81893521 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 6d3c246 into apache:develop Apr 27, 2020
xiaowan pushed a commit to xiaowan/seata that referenced this pull request Apr 30, 2020
@objcoding
bugfix: nacos-script adapt to nacos 1.2 on permission control. (apach…
44cd477 
…e#2610)
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

nacos cannot upload configuration after enabling authentication
5 participants
@objcoding @codecov-io @l81893521 @slievrly @funky-eyes