docs: fix typo and some coding guidelines #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slievrly
changed the title
|
@XavierChengZW thanks for you contribution. |
…e added @OverRide,a static field should be directly referred by its class name,members of a POJO class wrapper classes
Codecov Report
@@ Coverage Diff @@
## develop #2613 +/- ##
=============================================
- Coverage 51.18% 51.17% -0.02%
+ Complexity 2806 2804 -2
=============================================
Files 554 554
Lines 17772 17772
Branches 2099 2099
=============================================
- Hits 9096 9094 -2
Misses 7819 7819
- Partials 857 859 +2
|
XavierChengZW
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r#proceed
Ⅰ. Describe what this PR did
fix typo for io.seata.rm.tcc.interceptor.ActionInterceptorHandler#proceed
fix some coding guidelines analyze
fix io.seata.core.rpc.netty.RpcServerBootstrap#start A static field should be directly referred by its class name instead of its corresponding object name.
fix io.seata.core.store.db.sql.log.AbstractLogStoreSqls#getQueryGlobalMax,io.seata.core.store.db.sql.log.AbstractLogStoreSqls#getQueryBranchMax.An overridden method from an interface or abstract class must be marked with @OverRide annotation.
fix io.seata.core.store.GlobalTransactionDO. Members of a POJO class must be wrapper classes.
Ⅱ. Does this pull request fix one issue?
Not
Ⅲ. Why don't you add test cases (unit test/integration test)?
No validation required
Ⅳ. Describe how to verify it
No validation required
Ⅴ. Special notes for reviews
Not