feature: TCC adapter for Dubbo And Sofa reference annotation #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2616 +/- ##
=============================================
- Coverage 50.14% 50.02% -0.12%
Complexity 2952 2952
=============================================
Files 591 592 +1
Lines 18954 18998 +44
Branches 2285 2290 +5
=============================================
Hits 9504 9504
- Misses 8505 8549 +44
Partials 945 945
|
q294881866
force-pushed
the
feature_tcc_annotation
branch
from
a65bcd9
to
a75e8dd
Compare
slievrly
reviewed
Jun 16, 2020
| } | ||
|
|
||
| ReflectionUtils.doWithFields(bean.getClass(), field -> { | ||
| Annotation reference = field.getAnnotation(annotation); |
There was a problem hiding this comment.
if necessary? FieldFilter check the filed contains annotation.
There was a problem hiding this comment.
The code impossible to reuse.
There was a problem hiding this comment.
What I mean is that reference can never null， field.isAnnotationPresent(annotation)
| return; | ||
| } | ||
|
|
||
| addTccAdvise(bean, beanName, field, field.getType()); |
There was a problem hiding this comment.
Previously, it was implemented with dubbo and sofa interface, but there were many repetitions. In fact, it's the only one that's different. There's no need to use an interface
`static {
ANNOTATIONS.add(loadAnnotation("org.apache.dubbo.config.annotation.Reference"));
ANNOTATIONS.add(loadAnnotation("com.alipay.sofa.runtime.api.annotation.SofaReference"));
ANNOTATIONS.add(loadAnnotation( ...
}`
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Support Dubbo @reference and sofa @SofaReference annotation for TCC mode
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews